Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quincy: mds: display sane hex value (0x0) for empty feature bit #52127

Merged
merged 1 commit into from
Aug 17, 2023
Merged

quincy: mds: display sane hex value (0x0) for empty feature bit #52127

merged 1 commit into from
Aug 17, 2023

Conversation

joscollin
Copy link
Member

@joscollin joscollin commented Jun 20, 2023 •
edited

Fixes: https://tracker.ceph.com/issues/61736
(cherry picked from commit 2ee9b3a)

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@joscollin
mds: display sane hex value (0x0) for empty feature bit
545b044 
Print a valid hex (0x0) during empty feature bit, so that the clients could recognize it.
When the _vec size becomes 0, print() function creates an invalid hex (0x) and 'perf stats'
crashes with the below error:
"
File "/opt/ceph/src/pybind/mgr/stats/fs/perf_stats.py", line 177, in notify_cmd
metric_features = int(metadata[CLIENT_METADATA_KEY]["metric_spec"]["metric_flags"]["feature_bits"], 16)
ValueError: invalid literal for int() with base 16: '0x'
"
This patch creates  a valid hex (0x0), when _vec size is 0.

Fixes: https://tracker.ceph.com/issues/59551
Signed-off-by: Jos Collin <jcollin@redhat.com>
(cherry picked from commit 2ee9b3a)
@github-actions github-actions bot added the cephfs Ceph File System label Jun 20, 2023
@github-actions github-actions bot added this to the quincy milestone Jun 20, 2023
@joscollin
Copy link
Member Author

jenkins test make check

@joscollin joscollin requested a review from a team June 20, 2023 12:20
batrick
batrick approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@batrick batrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://tracker.ceph.com/projects/cephfs/wiki/Quincy#2023-August-08

@yuriw yuriw merged commit a4e308f into ceph:quincy Aug 17, 2023
14 of 15 checks passed
@joscollin joscollin deleted the wip-61736-quincy branch August 18, 2023 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@batrick batrick batrick approved these changes

Assignees
No one assigned
Labels
cephfs Ceph File System needs-qa wip-yuri5-testing
Projects
None yet
Milestone
quincy
4 participants
@joscollin @batrick @vshankar @yuriw